New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<button> and <a> different font size in footer #3998

Closed
H2Os opened this Issue Apr 10, 2012 · 3 comments

Comments

Projects
None yet
6 participants
@H2Os

H2Os commented Apr 10, 2012

An a link defaults to mini in a footer, but a button doesn't.

Markup:

   <div data-role="footer" data-theme="e">
        <button type="button" id="skillSelect_Save" data-icon="check">Save</button>
        <a href="#" data-type="button" data-rel="back" data-icon="delete">Close</a>
    </div><!-- /footer -->

Tested on IE9, Chrome 18.0.1025.152 m, FF 11.0, Safari (5.1.5 for Windows and iOS 5.1 on iPad and iPhone 4S) and Opera 11.61.

@ghost ghost assigned Wilto Apr 11, 2012

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 28, 2012

Contributor

You're right - all buttons, regardless of markup, should be mini by default in toolbars.
http://jsbin.com/upular

Contributor

toddparker commented Apr 28, 2012

You're right - all buttons, regardless of markup, should be mini by default in toolbars.
http://jsbin.com/upular

@patrick-wolf

This comment has been minimized.

Show comment
Hide comment
@patrick-wolf

patrick-wolf Jul 3, 2012

Has the last pull request made it into 1.1.1RC1? Because I still see the old behavior of not automatically setting data-mini="true" for buttons using <button> markup. Note: I have merged the changes of #4638 into my 1.1.1RC1 codebase.
In "master" everything is working fine.

patrick-wolf commented Jul 3, 2012

Has the last pull request made it into 1.1.1RC1? Because I still see the old behavior of not automatically setting data-mini="true" for buttons using <button> markup. Note: I have merged the changes of #4638 into my 1.1.1RC1 codebase.
In "master" everything is working fine.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 3, 2012

Member

@patrickwolfat

Thanks for your comment.
It looks like we forgot to cherry-pick this fix into the branch that is used for the 1.1.1RC1 release :(
I am afraid this means it has to wait for the 1.1.2 and 1.2 releases.

Member

jaspermdegroot commented Jul 3, 2012

@patrickwolfat

Thanks for your comment.
It looks like we forgot to cherry-pick this fix into the branch that is used for the 1.1.1RC1 release :(
I am afraid this means it has to wait for the 1.1.2 and 1.2 releases.

jaspermdegroot added a commit that referenced this issue Jul 12, 2012

Merge pull request #4363 from uGoMobi/issue_#3998
Fixes #3998 - All buttons, regardless of markup, should be mini by default in toolbars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment