Skip to content
This repository

<button> and <a> different font size in footer #3998

Closed
H2Os opened this Issue April 10, 2012 · 3 comments

6 participants

H2Os Mat Marquis Scott Jehl Todd Parker Patrick Wolf Jasper de Groot
H2Os
H2Os commented April 10, 2012

An a link defaults to mini in a footer, but a button doesn't.

Markup:

   <div data-role="footer" data-theme="e">
        <button type="button" id="skillSelect_Save" data-icon="check">Save</button>
        <a href="#" data-type="button" data-rel="back" data-icon="delete">Close</a>
    </div><!-- /footer -->

Tested on IE9, Chrome 18.0.1025.152 m, FF 11.0, Safari (5.1.5 for Windows and iOS 5.1 on iPad and iPhone 4S) and Opera 11.61.

Todd Parker

You're right - all buttons, regardless of markup, should be mini by default in toolbars.
http://jsbin.com/upular

Scott Jehl scottjehl closed this in a618f80 May 21, 2012
Patrick Wolf

Has the last pull request made it into 1.1.1RC1? Because I still see the old behavior of not automatically setting data-mini="true" for buttons using <button> markup. Note: I have merged the changes of #4638 into my 1.1.1RC1 codebase.
In "master" everything is working fine.

Jasper de Groot
Owner

@patrickwolfat

Thanks for your comment.
It looks like we forgot to cherry-pick this fix into the branch that is used for the 1.1.1RC1 release :(
I am afraid this means it has to wait for the 1.1.2 and 1.2 releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.