New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selects with an id containing a period don't open their popup #5893

Closed
thojo opened this Issue Apr 17, 2013 · 0 comments

Comments

Projects
None yet
1 participant
@thojo

thojo commented Apr 17, 2013

Clicking on selects with data-native-menu="false" and an id containing a period like id="select1.id" does not show the menu/popup.
In version 1.1.1, it still worked.

1.3.0: http://jsbin.com/opegav/1
1.1.1: http://jsbin.com/afesef/1
Both with jQuery 1.7.2.

gabrielschulhof added a commit that referenced this issue Apr 17, 2013

gabrielschulhof added a commit that referenced this issue Apr 30, 2013

Revert "Custom select: Escape weird characters in popup/dialog ID whe…
…n they become hrefs. Fixes #5893."

This reverts commit f0b2417.

Conflicts:
	js/widgets/forms/select.custom.js

It is better to set the href to something valid rather than something that has escaped characters. The responsibility for correctly identifying elements based on a valid href goes to navigation/popup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment