New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive panel: disable "dismiss" on wide viewports no longer works #6317

Closed
globalmatt opened this Issue Aug 9, 2013 · 0 comments

Comments

Projects
None yet
2 participants
@globalmatt
Contributor

globalmatt commented Aug 9, 2013

With responsive panels, the expected behaviour is that the "tap outside to dismiss" feature is disabled if the viewport is wide:

http://view.jquerymobile.com/1.4.0-alpha.1/dist/demos/widgets/panels/

This used to work on 1.3, but it doesn't work on 1.4.0-alpha.1 or latest. You can still tap outside the panel to dismiss it, even in wide viewports:

http://jsbin.com/ofuhaw/148/edit

This appears to be due to the fact that the .ui-panel-dismiss-display-push div is now appended after the .ui-responsive-panel page div, meaning that the descendent selector .ui-responsive-panel .ui-panel-dismiss-display-push in http://code.jquery.com/mobile/1.4.0-alpha.1/jquery.mobile-1.4.0-alpha.1.css can no longer select the .ui-panel-dismiss-display-push div.

In 1.3 the .ui-panel-dismiss-display-push div was added inside the page div.

@ghost ghost assigned jaspermdegroot Aug 9, 2013

jaspermdegroot added a commit that referenced this issue Aug 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment