New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel panelclose event does not work (jquery mobile 1.4) #7058

Closed
dgruzda opened this Issue Feb 3, 2014 · 1 comment

Comments

Projects
None yet
3 participants
@dgruzda

dgruzda commented Feb 3, 2014

If I attach multiple event handlers simultaneously using a plain object, panelclose event does not work:
$(document).off("panelopen panelclose", '[name="panel_2"]').on({
panelopen: function() {
alert('Panel open');
},
panelclose: function() {
alert('Panel close');
}
}, '[name="panel_2"]');

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Feb 3, 2014

Member

@dgruzda

Thanks for reporting the issue.
The problem seems to be this line: https://github.com/jquery/jquery-mobile/blob/master/js/widgets/panel.js#L291
Test page: http://jsbin.com/AKOmUxa/107/edit
Using a plain object is not relevant so I am going to remove that from the title.

Ps. Please, always include a test page when reporting issues. See our contributing guidelines. Thanks!

Member

jaspermdegroot commented Feb 3, 2014

@dgruzda

Thanks for reporting the issue.
The problem seems to be this line: https://github.com/jquery/jquery-mobile/blob/master/js/widgets/panel.js#L291
Test page: http://jsbin.com/AKOmUxa/107/edit
Using a plain object is not relevant so I am going to remove that from the title.

Ps. Please, always include a test page when reporting issues. See our contributing guidelines. Thanks!

cgack added a commit to cgack/jquery-mobile that referenced this issue Mar 19, 2014

Panel: panelclose event does not work
panelclose is not bound to document after _openPanel

Fixes gh-7058

@gabrielschulhof gabrielschulhof added this to the 1.4.3 milestone Mar 19, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Apr 24, 2014

Panel: panelclose event does not work
altered to use _on and _off

Fixes gh-7058

cgack added a commit to cgack/jquery-mobile that referenced this issue Apr 24, 2014

Panel: panelclose event does not work
altered _on and added another test

Fixes gh-7058

cgack added a commit to cgack/jquery-mobile that referenced this issue May 29, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Jun 13, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Jun 13, 2014

Panel: panelclose event does not work
panelclose is not bound to document after _openPanel

Fixes gh-7058

Panel: panelclose event does not work

altered to use _on and _off

Fixes gh-7058

Panel: panelclose event does not work

altered _on and added another test

Fixes gh-7058

Panel: panelclose event does not work

fix use of _on

Fixes gh-7058

Panel: panelclose event does not work

Fixes gh-7058

cgack added a commit to cgack/jquery-mobile that referenced this issue Jun 14, 2014

cgack added a commit to cgack/jquery-mobile that referenced this issue Jun 14, 2014

@arschmitz arschmitz closed this in 3df9b3b Jun 14, 2014

arschmitz added a commit that referenced this issue Jun 16, 2014

agcolom added a commit to agcolom/jquery-mobile that referenced this issue Nov 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment