Permalink
Show file tree
Hide file tree
4 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Tabs: Removed all templating features. Fixes #7158 - Tabs: Remove add…
… and remove methods. Fixes #7157 - Tabs: Remove templating (idPrefix, tabTemplate, panelTemplate options). Fixes #7149 - Tabs: Remove use of title attribute.
- Loading branch information
1 parent
056f83f
commit 054b208a9990fd71d30285e707ad53dae5a48247
Showing
10 changed files
with
2 additions
and
504 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -36,7 +36,6 @@ | ||
//"sortable/sortable.html", | ||
"spinner/spinner.html", | ||
"tabs/tabs.html", | ||
"tabs/tabs_deprecated.html", | ||
"tooltip/tooltip.html", | ||
"widget/widget.html" | ||
]; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -36,7 +36,6 @@ | ||
//"sortable/sortable.html", | ||
"spinner/spinner.html", | ||
"tabs/tabs.html", | ||
"tabs/tabs_deprecated.html", | ||
"tooltip/tooltip.html", | ||
"widget/widget.html" | ||
]; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
054b208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our code currently makes use of tabTemplate. What should we use instead now that it has been removed?
054b208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we also use "add" and "remove" too. Is this gone forever? Is there any alternatives for more control over tabs templating and behavior?
054b208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rosenfeld have you checked out the relevant part of the upgrade guide? http://jqueryui.com/upgrade-guide/1.9/#deprecated-idprefix-tabtemplate-and-paneltemplate-options-use-refresh-method
054b208
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reference, @jzaefferer!
The document only references "refresh", which is great, but I couldn't find how to detect the close event and take some action upon its occurrence (old "remove" option).