Skip to content
Permalink
Browse files

Tabs: Removed all templating features. Fixes #7158 - Tabs: Remove add…

… and remove methods. Fixes #7157 - Tabs: Remove templating (idPrefix, tabTemplate, panelTemplate options). Fixes #7149 - Tabs: Remove use of title attribute.
  • Loading branch information
scottgonzalez committed Oct 25, 2012
1 parent 056f83f commit 054b208a9990fd71d30285e707ad53dae5a48247
@@ -29,7 +29,6 @@ var versions = {
//"sortable/sortable.html",
"Spinner": "spinner/spinner.html",
"Tabs": "tabs/tabs.html",
"Tabs_deprecated": "tabs/tabs_deprecated.html",
"Tooltip": "tooltip/tooltip.html",
"Widget": "widget/widget.html"
};
@@ -281,7 +281,7 @@ grunt.initConfig({
files: grunt.file.expandFiles( "tests/unit/**/*.html" ).filter(function( file ) {
// disabling everything that doesn't (quite) work with PhantomJS for now
// TODO except for all|index|test, try to include more as we go
return !( /(all|all-active|index|test|draggable|droppable|selectable|resizable|sortable|dialog|slider|datepicker|tabs|tabs_deprecated|tooltip)\.html$/ ).test( file );
return !( /(all|all-active|index|test|draggable|droppable|selectable|resizable|sortable|dialog|slider|datepicker|tabs|tooltip)\.html$/ ).test( file );
})
},
lint: {
@@ -36,7 +36,6 @@
//"sortable/sortable.html",
"spinner/spinner.html",
"tabs/tabs.html",
"tabs/tabs_deprecated.html",
"tooltip/tooltip.html",
"widget/widget.html"
];
@@ -36,7 +36,6 @@
//"sortable/sortable.html",
"spinner/spinner.html",
"tabs/tabs.html",
"tabs/tabs_deprecated.html",
"tooltip/tooltip.html",
"widget/widget.html"
];
@@ -8,8 +8,7 @@ var versions = [
],
additionalTests = {
accordion: [ "accordion_deprecated.html" ],
position: [ "position_deprecated.html" ],
tabs: [ "tabs_deprecated.html" ]
position: [ "position_deprecated.html" ]
};

window.testAllVersions = function( widget ) {
@@ -5,9 +5,6 @@
<title>jQuery UI Tabs Test Suite</title>

<script src="../../jquery.js"></script>
<script>
$.uiBackCompat = false;
</script>
<link rel="stylesheet" href="../../../external/qunit.css">
<script src="../../../external/qunit.js"></script>
<script src="../../jquery.simulate.js"></script>

This file was deleted.

This file was deleted.

4 comments on commit 054b208

@rosenfeld

This comment has been minimized.

Copy link

@rosenfeld rosenfeld replied Nov 9, 2012

Our code currently makes use of tabTemplate. What should we use instead now that it has been removed?

@rosenfeld

This comment has been minimized.

Copy link

@rosenfeld rosenfeld replied Nov 9, 2012

Actually we also use "add" and "remove" too. Is this gone forever? Is there any alternatives for more control over tabs templating and behavior?

@jzaefferer

This comment has been minimized.

Copy link
Member

@jzaefferer jzaefferer replied Nov 9, 2012

@rosenfeld

This comment has been minimized.

Copy link

@rosenfeld rosenfeld replied Nov 9, 2012

Thank you for the reference, @jzaefferer!

The document only references "refresh", which is great, but I couldn't find how to detect the close event and take some action upon its occurrence (old "remove" option).

Please sign in to comment.
You can’t perform that action at this time.