Button: Adding quotes to the attribute selector for labels - Fixes #7…

…534 - Button label selector omits quotes / fails for ids with ":"
jquery · Aug 4, 2011 · 065aef5 · 065aef5
1 parent 6fb6856
commit 065aef5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/tests/unit/button/button_tickets.js b/tests/unit/button/button_tickets.js
@@ -50,4 +50,10 @@ test( "#7092 - button creation that requires a matching label does not find labe
 	ok( group.find( "label" ).is( ".ui-button" ) );
 });
 
+test( "#7534 - Button label selector works for ids with \":\"", function() {
+	var group = $( "<span><input type='checkbox' id='check:7534'><label for='check:7534'>Label</label></span>" );
+	group.find( "input" ).button();
+	ok( group.find( "label" ).is( ".ui-button" ), "Found an id with a :" );
+});
+
 })( jQuery );
diff --git a/ui/jquery.ui.button.js b/ui/jquery.ui.button.js
@@ -229,7 +229,7 @@ $.widget( "ui.button", {
 			// we don't search against the document in case the element
 			// is disconnected from the DOM
 			var ancestor = this.element.parents().last(),
-				labelSelector = "label[for=" + this.element.attr("id") + "]";
+				labelSelector = "label[for='" + this.element.attr("id") + "']";
 			this.buttonElement = ancestor.find( labelSelector );
 			if ( !this.buttonElement.length ) {
 				ancestor = ancestor.length ? ancestor.siblings() : this.element.siblings();