Spinner: Remove redundant handling of disabled option on create

Ref #9151 Ref gh-1599
jquery · Sep 25, 2015 · 1397ce4 · 1397ce4
1 parent 897dc71
commit 1397ce4
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/ui/widgets/spinner.js b/ui/widgets/spinner.js
@@ -268,11 +268,6 @@ $.widget( "ui.spinner", {
 				this.uiSpinner.height() > 0 ) {
 			this.uiSpinner.height( this.uiSpinner.height() );
 		}
-
-		// Disable spinner if element was already disabled
-		if ( this.options.disabled ) {
-			this.disable();
-		}
 	},
 
 	_keydown: function( event ) {
@@ -427,12 +422,14 @@ $.widget( "ui.spinner", {
 		}
 
 		this._super( key, value );
+	},
 
-		if ( key === "disabled" ) {
+	_setOptionDisabled: function( value ) {
-			this._toggleClass( this.uiSpinner, null, "ui-state-disabled", !!value );
+		this._super( value );
-			this.element.prop( "disabled", !!value );
+
-			this.buttons.button( value ? "disable" : "enable" );
+		this._toggleClass( this.uiSpinner, null, "ui-state-disabled", !!value );
-		}
+		this.element.prop( "disabled", !!value );
+		this.buttons.button( value ? "disable" : "enable" );
 	},
 
 	_setOptions: spinnerModifer( function( options ) {