Skip to content

Commit

Permalink
Build: Install shell dependencies in the right direcytory. Update tra…
Browse files Browse the repository at this point in the history
…c instructions to point out that only minutes and seconds need to be changed. Fixes #8848 - Build: release.js fails to require shelljs/global.
  • Loading branch information
jzaefferer committed Nov 25, 2012
1 parent d7adc2b commit 62ae078
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions build/release/release.js
Expand Up @@ -262,8 +262,9 @@ function gatherContributors() {

function updateTrac() {
echo( newVersion.cyan + " was tagged at " + tagTime.cyan + "." );
echo( "Close the " + newVersion.cyan + " Milestone with the above date and time." );
echo( "Create the " + newVersion.cyan + " Version with the above date and time." );
echo( "Close the " + newVersion.cyan + " Milestone." );
echo( "Create the " + newVersion.cyan + " Version." );
echo( "When Trac asks for date and time, match the above. Should only change minutes and seconds." );
echo( "Create a Milestone for the next minor release." );
}

Expand Down Expand Up @@ -342,9 +343,7 @@ function bootstrap( fn ) {
fs.mkdirSync( baseDir );

console.log( "Installing dependencies..." );
require( "child_process" ).exec( "npm install shelljs colors", {
cwd: baseDir
}, function( error ) {
require( "child_process" ).exec( "npm install shelljs colors", function( error ) {
if ( error ) {
console.log( error );
return process.exit( 1 );
Expand Down

1 comment on commit 62ae078

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I didn't use the current directory because I wanted all generated files to be contained.

Please sign in to comment.