Progressbar: Modified value method to act as both a getter and setter…

…. Fixed #4427 - progressbar('value') returns a reference to this instead of the value.
jquery · Apr 16, 2009 · 62f11b4 · 62f11b4
1 parent 1195854
commit 62f11b4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/tests/unit/progressbar/progressbar_methods.js b/tests/unit/progressbar/progressbar_methods.js
@@ -24,4 +24,13 @@ test("destroy", function() {
 	equals(actual, expected, 'destroy is chainable');
 });
 
+test('value', function() {
+	expect(3);
+
+	var el = $('<div></div>').progressbar({ value: 20 });
+	equals(el.progressbar('value'), 20, 'correct value as getter');
+	equals(el.progressbar('value', 30), el, 'chainable as setter');
+	equals(el.progressbar('option', 'value'), 30, 'correct value after setter');
+});
+
 })(jQuery);
diff --git a/ui/ui.progressbar.js b/ui/ui.progressbar.js
@@ -56,8 +56,12 @@ $.widget("ui.progressbar", {
 	},
 
 	value: function(newValue) {
-		arguments.length && this._setData("value", newValue);
+		if (newValue === undefined) {
-		return this._value();
+			return this._value();
+		}
+
+		this._setData('value', newValue);
+		return this;
 	},
 
 	_setData: function(key, value) {