Skip to content

Commit

Permalink
Selectmenu: menu focus reset when menu is closed, prevents issues whe…
Browse files Browse the repository at this point in the history
…n using keyboard control on button when focusing menu item before
  • Loading branch information
fnagel committed Feb 13, 2013
1 parent 75cfcf2 commit 640d308
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions ui/jquery.ui.selectmenu.js
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ $.widget( "ui.selectmenu", {
focus: function( event, ui ) { focus: function( event, ui ) {
var item = ui.item.data( "ui-selectmenu-item" ); var item = ui.item.data( "ui-selectmenu-item" );
// prevent inital focus from firing and checks if its a newly focused item // prevent inital focus from firing and checks if its a newly focused item
if ( that.focus !== undefined && item.index !== that.focus ) { if ( !that.isOpen && that.focus !== undefined && item.index !== that.focus ) {
that._trigger( "focus", event, { item: item } ); that._trigger( "focus", event, { item: item } );
if ( !that.isOpen ) { if ( !that.isOpen ) {
that._select( item, event ); that._select( item, event );
Expand Down Expand Up @@ -206,7 +206,10 @@ $.widget( "ui.selectmenu", {


// check if we have an item to select // check if we have an item to select
if ( this.menuItems ) { if ( this.menuItems ) {
var id = this._getSelectedItem().find( "a" ).attr( "id" ); var item = this._getSelectedItem(),
id = item.find( "a" ).attr( "id" );

this.menu.menu( "focus", null, item );
this.button.attr( "aria-activedescendant", id ); this.button.attr( "aria-activedescendant", id );
this.menu.attr( "aria-activedescendant", id ); this.menu.attr( "aria-activedescendant", id );
} }
Expand Down

0 comments on commit 640d308

Please sign in to comment.