Skip to content
Permalink
Browse files

Selectable: Account for scrolling on the helper's initial position. F…

…ixed #8915 - Selectable: Lasso offset issue with scrolling.
  • Loading branch information...
tjvantoll authored and scottgonzalez committed Dec 29, 2012
1 parent 2620be8 commit 695358983e58c9f3d0c6b755ce89fa92adbea0ea
Showing with 30 additions and 2 deletions.
  1. +28 −0 tests/unit/selectable/selectable_events.js
  2. +2 −2 ui/jquery.ui.selectable.js
@@ -35,4 +35,32 @@ test( "stop", function() {
});
});

test( "mousedown: initial position of helper", function() {
expect( 2 );

var contentToForceScroll, helper,
element = $("#selectable1").selectable();

contentToForceScroll = $("<div>").css({
height: "10000px",
width: "10000px"
});

contentToForceScroll.appendTo("body");
$( window ).scrollTop( 1 ).scrollLeft( 1 );
element.simulate( "mousedown", {
clientX: 10,
clientY: 10
});

helper = $(".ui-selectable-helper");
equal( helper.css("top"), "11px", "Scroll top should be accounted for." );
equal( helper.css("left"), "11px", "Scroll left should be accounted for." );

// Cleanup
element.simulate("mouseup");
contentToForceScroll.remove();
$( window ).scrollTop( 0 ).scrollLeft( 0 );
});

})( jQuery );
@@ -88,8 +88,8 @@ $.widget("ui.selectable", $.ui.mouse, {
$(options.appendTo).append(this.helper);
// position helper (lasso)
this.helper.css({
"left": event.clientX,
"top": event.clientY,
"left": event.pageX,
"top": event.pageY,
"width": 0,
"height": 0
});

0 comments on commit 6953589

Please sign in to comment.
You can’t perform that action at this time.