Skip to content
Permalink
Browse files

droppable: a small performance improvement by not using :visible, and…

… deferring to a simpler syntax of checking for diplay none
  • Loading branch information
Paul Bakaus
Paul Bakaus committed Jul 3, 2008
1 parent 6e75723 commit 6aaf1598d2403466f6d94a95fa03858f6daf4134
Showing with 3 additions and 1 deletion.
  1. +3 −1 ui/ui.droppable.js
@@ -176,9 +176,10 @@ $.ui.ddmanager = {

var m = $.ui.ddmanager.droppables;
var type = e ? e.type : null; // workaround for #2317

for (var i = 0; i < m.length; i++) {
if(m[i].options.disabled || (t && !m[i].options.accept.call(m[i].element,(t.currentItem || t.element)))) continue;
m[i].visible = m[i].element.is(":visible"); if(!m[i].visible) continue; //If the element is not visible, continue
m[i].visible = m[i].element.css("display") == "none"; if(!m[i].visible) continue; //If the element is not visible, continue
m[i].offset = m[i].element.offset();
m[i].proportions = { width: m[i].element[0].offsetWidth, height: m[i].element[0].offsetHeight };

@@ -210,6 +211,7 @@ $.ui.ddmanager = {
if(draggable.options.refreshPositions) $.ui.ddmanager.prepareOffsets(draggable, e);

//Run through all droppables and check their positions based on specific tolerance options

$.each($.ui.ddmanager.droppables, function() {

if(this.options.disabled || this.greedyChild || !this.visible) return;

0 comments on commit 6aaf159

Please sign in to comment.
You can’t perform that action at this time.