Skip to content

Commit

Permalink
Build: Remove grunt concat task its no longer used
Browse files Browse the repository at this point in the history 
This task was only used to create the combined js file for sizer
and for creating the combined files for the NPM package. The
npm package is no longer maintained so there is no need for this any more.
  • Loading branch information
@arschmitz
arschmitz committed Aug 8, 2015
1 parent a486903 commit 7cb0a2b
Showing 1 changed file with 0 additions and 42 deletions.
42 changes: 0 additions & 42 deletions Gruntfile.js
View file
Expand Up @@ -24,29 +24,6 @@ var


allI18nFiles = expandFiles( "ui/i18n/*.js" ), allI18nFiles = expandFiles( "ui/i18n/*.js" ),


cssFiles = [
"core",
"accordion",
"autocomplete",
"button",
"datepicker",
"dialog",
"draggable",
"menu",
"progressbar",
"resizable",
"selectable",
"selectmenu",
"sortable",
"slider",
"spinner",
"tabs",
"tooltip",
"theme"
].map(function( component ) {
return "themes/base/" + component + ".css";
}),

// minified files // minified files
minify = { minify = {
options: { options: {
Expand Down Expand Up @@ -149,25 +126,6 @@ grunt.initConfig({
dist: "<%= pkg.name %>-<%= pkg.version %>" dist: "<%= pkg.name %>-<%= pkg.version %>"
}, },
compare_size: compareFiles, compare_size: compareFiles,
concat: {
i18n: {
options: {
banner: createBanner( allI18nFiles )
},
src: allI18nFiles,
dest: "dist/i18n/jquery-ui-i18n.js"
},
css: {
options: {
banner: createBanner( cssFiles ),
stripBanners: {
block: true
}
},
src: cssFiles,
dest: "dist/jquery-ui.css"
}
},
requirejs: { requirejs: {
js: { js: {
options: { options: {
Expand Down

5 comments on commit 7cb0a2b

@chrishiebert
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference to Grunt concat task left in jquery-ui/README.md

The grunt concat task was removed from Gruntfile.js, however the "Building jQuery UI" section of the README.md still references the task.

Readme file:
[https://github.com/jquery/jquery-ui/blob/master/README.md]

Commit removing the task:
[https://github.com/jquery/jquery-ui/commit/7cb0a2ba890e6a5c921d74e1c563b57359419311]

Attempted to submit a bug report.

Trac Error
Submission rejected as potential spam (Maximum number of posts per hour for this IP (127.0.0.1) exceeded)

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrishiebert Thanks, I've removed that section since it's no longer relevant.

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess what else we missed! This was used by Jenkins to upload git builds to the CDN. Accordingly those builds haven been broken since: http://jenkins.jquery.com/job/jQuery%20UI/

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which I think we can replace with the new requirejs task. Trying that...

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixes the build (which doesn't look too bad either: http://swarm.jquery.org/job/1295 ), but we still lost dist/jquery-ui.css.

Please sign in to comment.