Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Selectmenu: Don't render options with the
hidden
attribute
Fixes #15098
- Loading branch information
1 parent
9a4c057
commit a2b25ef
Showing
2 changed files
with
30 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2b25ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried cherrypicking this onto v1.12.1, but it actually causes a regression. If I select the last visible item, the select button stops working. There's a mismatch between indices, resulting in trying to grab index from an undefined element.
a2b25ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #2144