Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sortable: Calculating item distance and direction using a more robust…
… algorithm to better support sorting among nested sortables. Fixes #8572 - Wrong placeholder positions. Fixes #8573 - Can't drag an item out of an inner sortable. Fixes #8574 - Hard to put an item between two inner sortables. Use the item which has the least distance between the mouse pointer and one of its borders to rearrange, with direction being determined by the nearest border. Also we use this algorithm to rearrange even when currentContainer is not changed to override the defective rearrangment in _mouseDrag
- Loading branch information
bae06d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this commit screws up the way that sortable was working.
I had an interface working perfectly with the 1.9 version, but now on 1.9.1 sortable won't work at all with nested elements.
Are you sure this didn't mess with nesting?
bae06d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified. This commit causes bugs especially when using nested divs.
bae06d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arpowers, thanks please provide a test case on the bug tracker at http://bugs.jqueryui.com
bae06d2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhizhangchen John, could you sign our CLA? http://jquery.github.com/cla.html Thanks.