Skip to content
Browse files

Tabs: Show panels on destroy. Fixes #8795 - Tabs: 'display: none;' at…

…tribute is not removed from tabs when destroy is called.
  • Loading branch information...
1 parent dbaecf0 commit fd48568c402847df8af59166c33549f0d19feb4b @scottgonzalez scottgonzalez committed Nov 9, 2012
Showing with 30 additions and 0 deletions.
  1. +28 −0 tests/unit/testsuite.js
  2. +2 −0 ui/jquery.ui.tabs.js
View
28 tests/unit/testsuite.js
@@ -205,6 +205,33 @@ window.domEqual = function( selector, modifier, message ) {
"title"
];
+ function getElementStyles( elem ) {
+ var key, len,
+ style = elem.ownerDocument.defaultView ?
+ elem.ownerDocument.defaultView.getComputedStyle( elem, null ) :
+ elem.currentStyle,
+ styles = {};
+
+ if ( style && style.length && style[ 0 ] && style[ style[ 0 ] ] ) {
+ len = style.length;
+ while ( len-- ) {
+ key = style[ len ];
+ if ( typeof style[ key ] === "string" ) {
+ styles[ $.camelCase( key ) ] = style[ key ];
+ }
+ }
+ // support: Opera, IE <9
+ } else {
+ for ( key in style ) {
+ if ( typeof style[ key ] === "string" ) {
+ styles[ key ] = style[ key ];
+ }
+ }
+ }
+
+ return styles;
+ }
+
function extract( elem ) {
if ( !elem || !elem.length ) {
QUnit.push( false, actual, expected,
@@ -222,6 +249,7 @@ window.domEqual = function( selector, modifier, message ) {
var value = elem.attr( attr );
result[ attr ] = value !== undefined ? value : "";
});
+ result.style = getElementStyles( elem[ 0 ] );
result.events = $._data( elem[ 0 ], "events" );
result.data = $.extend( {}, elem.data() );
delete result.data[ $.expando ];
View
2 ui/jquery.ui.tabs.js
@@ -716,6 +716,8 @@ $.widget( "ui.tabs", {
}
});
+ this.panels.show();
+
if ( this.options.heightStyle !== "content" ) {
this.panels.css( "height", "" );
}

0 comments on commit fd48568

Please sign in to comment.
Something went wrong with that request. Please try again.