Button: Remove obsolete mouse click coordinates checking. Fixed #7665 - Radio button & checkboxes ignore mouseclicks for minor mouse movements

[UltCombo]

I've had someone asking about jQuery UI's ticket 7665 not long ago, so here's my recap of its history thus far:

As I've explained here, the #6970 bug fix introduced this code to completely prevent users from drag-clicking, instead of actually fixing the widget to work with drag-clicks. IMO this was a bad decision as it harms usability (mostly touch and high DPI input devices).

My fix for #5518 did take care of inconsistent double and drag-clicks, making the coordinates checking code obsolete.

Then, I've tried to push the PR 945 to remove all that obsolete code, but it has been stagnated ever since.

This PR is less audacious than my previous one in that instead of re-creating the whole clicking functionality, it simply removes obsolete code leaving the drag/click handling to the browser's default behavior.

Passes all current tests. Haven't added any new test because I believe this kind of browser behavior cannot be simulated.

[UltCombo]

Merging this pull also closes #945, since this is a simpler and more maintainable fix for the issue.

[scottgonzalez]

Thanks, landed in 8b64322. Would you mind updating your git config to contain your real name for future PRs?

[UltCombo]

@scottgonzalez No problem, will do. =]