Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match on exact node name #1417

Closed
wants to merge 1 commit into from
Closed

Match on exact node name #1417

wants to merge 1 commit into from

Conversation

SlimFoster
Copy link
Contributor

Custom elements may unintentionally match if they contain part of an name being searched for

@scottgonzalez
Copy link
Member

Thanks, I've filed http://bugs.jqueryui.com/ticket/10747 and http://bugs.jqueryui.com/ticket/10748 for this. Can you please sign our CLA so we can land this?

This should be split into two separate commits and include proper references to the tickets based on the commit guidelines, but I can do that myself after you've signed the CLA if you prefer.

@SlimFoster
Copy link
Contributor Author

I've signed the CLA. Yeah, if you wouldn't mind splitting the commit, that'd be nice.

@scottgonzalez
Copy link
Member

Thanks, do you want the commit to be changed to use the Gmail address you signed with? If not, please sign the CLA with the email address you have in your git config.

@SlimFoster
Copy link
Contributor Author

Yeah, I meant to commit with my gmail not my work email.

On Fri, Jan 9, 2015 at 2:28 PM, Scott González notifications@github.com
wrote:

Thanks, do you want the commit to be changed to use the Gmail address you
signed with? If not, please sign the CLA with the email address you have in
your git config.


Reply to this email directly or view it on GitHub
#1417 (comment).

scottgonzalez pushed a commit that referenced this pull request Jan 9, 2015
@scottgonzalez
Copy link
Member

No problem. I updated the author info and split into the two commits referenced above.

Thanks for the fix.

scottgonzalez pushed a commit that referenced this pull request Feb 9, 2015
scottgonzalez pushed a commit that referenced this pull request Feb 9, 2015
Fixes #10748
Closes gh-1417
(cherry picked from commit faefab8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants