Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datepicker.js to support showSelectorAtPos in multi-month scenario #1668

Closed
wants to merge 3 commits into from

Conversation

aquavark
Copy link

Added new setting "showSelectorAtPos" to control which position the month and year selectors appear in (zero based, as per showCurrentAtPos). Allows correction of the non-intuitive layout when you have multiple months, but the month you are selecting does not appear in the box that you are making the selections in.

Works by changing the check for "secondary" when building the month/year part of the month box in multiple month operation.

Add new setting showSelectorAtPos to control the calendar on which the month and year selectors are shown (works the same as showCurrentAtPos). Modifies the detection of "secondary" when calling _generateMonthYearHeader. Tested against both single row and multi row/column configurations. Enables the selection boxes to be in the same month as the one they are setting where showCurrentAtPos is non-zero. showSelectorAtPos is zero based to match showCurrentAtPos.
Updated with layout hints from first attempt
@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

LINT fixes again
@aquavark
Copy link
Author

Failure with Travis was present prior to pull request. CLA failure - have now signed it 4 times!

@scottgonzalez
Copy link
Member

Thanks, but we're not accepting any new features for datepicker as it is in the middle of a rewrite. In the future, please start by filing an issue to have discussion before sending a pull request. Of course you can still file an issue so we can discuss this for the new version. You can read about the process for contributing in CONTRIBUTING.md.

@aquavark
Copy link
Author

Which I would (as it's an important usability feature for us), but I can't log in to Trac on the jQuery-UI website, and the IRC developers channel appears to be dead for the past 24 hours. How do I log it?

@scottgonzalez
Copy link
Member

Just to close the loop on this, @aquavark did file the feature request on the planning wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants