Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3762 #9553 #15011 #15083 #1815

Closed
wants to merge 1 commit into from
Closed

#3762 #9553 #15011 #15083 #1815

wants to merge 1 commit into from

Conversation

determin1st
Copy link

No description provided.

@jsf-clabot
Copy link

jsf-clabot commented May 10, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@scottgonzalez
Copy link
Member

Why did you open a second PR for the same thing? This diff is even bigger than before with fewer commits. My comments were not addressed. There needs to be one commit per fix. You have four bugs listed, so I expect at least four commits, unless the bugs are directly related to each other. There need to be meaningful variable names, not random letters. Do not change indentation style from tabs to spaces. The code needs to follow our coding standards.

Please start by reading the contribution guidelines. If you have questions, please ask.

@scottgonzalez
Copy link
Member

Closing due to inactivity. Please file a new PR if you continue working on this. Thanks.

@determin1st
Copy link
Author

im unable to comply to the requirements, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants