Theme: Fix blank icons having a background #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix from 4325446 introduced a rule setting `background-image` of a blank icon to none. However, the selector used for that rule had lower specificity than another one: `.ui-button .ui-icon` which caused dashes being shown over the icons. We needed to increase the specificity of the `.ui-icon-blank` rule past the above selector and past `.ui-button:hover .ui-icon`. We're doing it by repeating the class name three times.
fnagel
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix from 4325446 introduced a rule setting
background-imageof a blank icon to none. However, the selector used for thatrule had lower specificity than another one:
.ui-button .ui-iconwhich causeddashes being shown over the icons.
We needed to increase the specificity of the
.ui-icon-blankrule past theabove selector and past
.ui-button:hover .ui-icon. We're doing it by repeatingthe class name three times.