Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Report compressed sizes in compare_size #2254

Merged
merged 1 commit into from
May 20, 2024

Conversation

mgol
Copy link
Member

@mgol mgol commented May 19, 2024

main version of #2248.

Just like it has always worked in Core. This will help with size comparisons between 1.13 & 1.14.

After this PR:

$ grunt sizer
Running "requirejs:js" (requirejs) task

Running "uglify:main" (uglify) task
>> 1 file created 549 kB → 267 kB

Running "compare_size:all" (compare_size) task
   raw     gz Sizes
549319 128757 dist/jquery-ui.js
266710  69612 dist/jquery-ui.min.js

Done.

Before, only the less interesting raw sizes were reported.

Just like it has always worked in Core. This will help with size comparisons
between 1.13 & 1.14.

After this PR:

```
$ grunt sizer
Running "requirejs:js" (requirejs) task

Running "uglify:main" (uglify) task
>> 1 file created 549 kB → 267 kB

Running "compare_size:all" (compare_size) task
   raw     gz Sizes
549319 128757 dist/jquery-ui.js
266710  69612 dist/jquery-ui.min.js

Done.
```

Before, only the less interesting `raw` sizes were reported.
@mgol mgol added this to the 1.14.0 milestone May 19, 2024
@mgol mgol requested a review from timmywil May 19, 2024 21:21
@mgol mgol requested a review from fnagel May 19, 2024 21:34
@mgol mgol self-assigned this May 19, 2024
@mgol mgol merged commit 9180a81 into jquery:main May 20, 2024
21 checks passed
@mgol mgol deleted the compare-size-main branch May 20, 2024 16:59
@mgol mgol removed the Needs review label May 20, 2024
mgol added a commit that referenced this pull request May 20, 2024
Just like it has always worked in Core. This will help with size comparisons
between 1.13 & 1.14.

After this PR:

```
$ grunt sizer
Running "requirejs:js" (requirejs) task

Running "uglify:main" (uglify) task
>> 1 file created 549 kB → 267 kB

Running "compare_size:all" (compare_size) task
   raw     gz Sizes
549319 128757 dist/jquery-ui.js
266710  69612 dist/jquery-ui.min.js

Done.
```

Before, only the less interesting `raw` sizes were reported.

Closes gh-2248
Ref gh-2254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants