Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Button: Added check to adjust icon position in browsers that do not follow the standard box model when displaying buttons (i.e. Firefox). Fixed #5603 #328

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

kborchers commented May 23, 2011

Button: Added check to adjust icon position in browsers that do not follow the standard box model when displaying buttons (i.e. Firefox). Fixed #5603 - Button with icon not displayed correctly in Firefox when button has css height.

@kborchers kborchers Button: Added check to adjust icon position in browsers that do not f…
…ollow the standard box model when displaying buttons (i.e. Firefox). Fixed #5603 - Button with icon not displayed correctly in Firefox when button has css height.
7c07a56
Owner

kborchers commented May 23, 2011

This is still not perfect but it is better than the current icon display. If the button text wraps to multiple lines due to a set width, the icon aligns with the first line in FF but otherwise, all browsers properly align the icon.

Owner

gnarf commented Jul 19, 2011

Not really sure if we need this, can you look into http://bugs.jqueryui.com/ticket/5603#comment:6 and let me know if that works to fix the issue / maybe put together a pull based on my investigations?

Owner

kborchers commented Jul 20, 2011

I want to say I tried that and it didn't work in a situation in FF where the width was set and the text in the button was longer so it wrapped. That caused unexpected positioning of the text. My solution, though not perfect was the only thing I could come up with that consistently positioned the text in all browsers, though FF was still different than the others, it was consistent.

Member

mikesherov commented Nov 10, 2012

@kborchers, @gnarf37 where are we at with this PR?

Member

mikesherov commented Nov 14, 2012

couldn't this be fixing by changing the box-sizing css property of the button to content-box? Also, in jQuery 1.8, I made .height() always return the content height, respecting box sizing. @kborchers, thoughts?

Member

mikesherov commented Nov 14, 2012

Actually, this was fixed in Firefox 10! Closing. If I'm wrong, reopen. Thanks guys!

@mikesherov mikesherov closed this Nov 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment