Button: Added check to adjust icon position in browsers that do not follow the standard box model when displaying buttons (i.e. Firefox). Fixed #5603

[kborchers]

Button: Added check to adjust icon position in browsers that do not follow the standard box model when displaying buttons (i.e. Firefox). Fixed #5603 - Button with icon not displayed correctly in Firefox when button has css height.

[kborchers]

This is still not perfect but it is better than the current icon display. If the button text wraps to multiple lines due to a set width, the icon aligns with the first line in FF but otherwise, all browsers properly align the icon.

[gnarf]

Not really sure if we need this, can you look into http://bugs.jqueryui.com/ticket/5603#comment:6 and let me know if that works to fix the issue / maybe put together a pull based on my investigations?

[kborchers]

I want to say I tried that and it didn't work in a situation in FF where the width was set and the text in the button was longer so it wrapped. That caused unexpected positioning of the text. My solution, though not perfect was the only thing I could come up with that consistently positioned the text in all browsers, though FF was still different than the others, it was consistent.

[mikesherov]

@kborchers, @gnarf37 where are we at with this PR?

[mikesherov]

couldn't this be fixing by changing the box-sizing css property of the button to content-box? Also, in jQuery 1.8, I made .height() always return the content height, respecting box sizing. @kborchers, thoughts?

[mikesherov]

Actually, this was fixed in Firefox 10! Closing. If I'm wrong, reopen. Thanks guys!