Selectmenu ARIA tweaks

[jzaefferer]

For code review, to eventually merge into the selectmenu branch. I've pushed the individual commits for now, we can squash that into one later.

There are currently a few tests failing - I haven't updated those yet.

I've tested with JAWS and NVDA under Windows and VoiceOver under OSX.

• NVDA/Firefox: Good
• NVDA/IE9: Good
• JAWS/Firefox: Good
• JAWS/IE9: Works, but value is announced two times when changing it
• VoiceOver/Safari: Unusable. Gets announced as combobox, but nothing else happens, at all. Native select is announced as "popup button" instead. Sucks, but then I also don't understand how anyone would use VO with Safari... I guess its good for native apps?

Feature wise this is probably as good as it gets, for now anyway. We can still improve later, but this is already much better then what we had.

Once the code is reviewed I'll sqaush and fix the unit tests.

[jzaefferer]

@fnagel could you test this?

[fnagel]

I'm not quite sure how this is possible but I've tested on Win7 with NVDA 2012.2.1 and JAWS 14.0.1102 :

• NVDA/Firefox: Works good, but it seems keyboard control is broken when menu is opened and NVDA is active.
• NVDA/IE9: Broken,reads partly wrong information multiple times and it seems keyboard control is broken when menu is opened and NVDA is active.
• JAWS/Firefox: Broken, almost no announcements
• JAWS/IE9: Works, but value is announced two times on first change

These are my test results from latest selectmenu branch:

• NVDA/FF: works good, but it seems keyboard control is broken when menu is opened. When NVDA is not active it works like expected.
• NVDA/IE9: works good, but reads value multiple times
• JAWS/FF: works with opened menu only
• JAWS/IE9: works good, but reads value multiple times

[kborchers]

I did some testing as well.

• NVDA/FF: Good (Did not notice broken keyboard control)
• NVDA/IE9: Good, multiple value reads (Wonder if it's reading the option text and the value)
• I don't have JAWS
• VoiceOver/Safari and VoiceOver/Chrome: Sort of works if the selectmenu is expanded but otherwise it doesn't really work

[fnagel]

Did you test FF / IE and NVDA on native Windows machine?

[jzaefferer]

For testing JAWS, you can download free demos here: http://www.freedomscientific.com/products/fs/jaws-product-page.asp

Would be good if you could also compare this branch to the selectmenu branch, since my and Felix' results differed so heavily.

[jzaefferer]

Btw. I tested in VirtualBox VM on Windows 7.

[fnagel]

I've tested FF + NVDA on another Win7 machine (and latest NVDA 2012.3.1) and the keyboard control is definitely broken when the menu is open.

[kborchers]

@fnagel Hmm, I'll check my NVDA version next time I switch to Windows. I'm running Win7 on my MBP via Bootcamp

[kborchers]

OK, got a chance to do more testing. I have the latest NVDA but I noticed that my previous tests must have been on the selectmenu branch not the selectmenu-aria-tweaks branch. Below are my results for the tweaks branch:

NVDA/FF - Seems to work OK. Keyboard worked fine but couldn't open the menu with spacebar.
NVDA/IE9 - Broken. Keyboard left/right can rotate through the values properly but up/down does some crazy jumping and multiple value reads before losing focus and then have to tab back to the selectmenu. The 3rd selectmenu in the default selectmenu demo seems to work ok but it reads the values twice.

[fnagel]

Mhh, so both branches do work partly but far from perfect. What now?

Shall I merge tweaks into selectmenu and we test again?

[jzaefferer]

Replaced by #931