Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortable: check default intersection by calculating surface overlap. Fixed #3022 and #8342 - incorrect behavior of 'intersect' tolerance option #915

Closed
wants to merge 1 commit into from

Conversation

ngsilverman
Copy link
Contributor

Fixed http://bugs.jqueryui.com/ticket/3022 and http://bugs.jqueryui.com/ticket/8342
#3022 - handle outside sorting element does not work
#8342 - incorrect behavior of 'intersect' tolerance option

…Fixed #3022 and #8342 - sortable: incorrect behavior of 'intersect' tolerance option
@mikesherov
Copy link
Member

@ngsilverman, can you provide some unit tests for these fixes?

@tjvantoll
Copy link
Member

@ngsilverman
Copy link
Contributor Author

@mikesherov, I'll look into it.

@tjvantoll, from what I can see #8342 has not been fixed because it's not a duplicate of #8274. If you remove the axis: 'x' from the fiddle you'll see that when you sort a tab and if the mouse pointer isn't over other tabs, it won't sort regardless of how large the intersection is.

@tjvantoll
Copy link
Member

@ngsilverman Good call. I reopened the ticket.

@scottgonzalez
Copy link
Member

@ngsilverman Are you still planning on writing tests for this?

@scottgonzalez
Copy link
Member

@ngsilverman @mikesherov What's the status of this? If it's not getting any traction, I'd like to close this.

@zakdances
Copy link

I'm still seeing this problem in Chrome even when the axis: 'x' option is set. The tolerance setting seems completely wonky regardless of what it's set at...sometimes it will require 100% overlap, other times a 50% overlap, and sometimes it even requires an item to be dragged all the way past the target item.

@jzaefferer
Copy link
Member

Closing due to lack of tests and activity. One underlying ticket is still open and has a reference to this, maybe someone can pick this up and write a test.

@jzaefferer jzaefferer closed this Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants