Fixed an issue with script nodes being removed incorrectly, fixes #3737.

jquery · Jan 10, 2009 · 29bf601 · 29bf601
1 parent afb0508
commit 29bf601
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/core.js b/src/core.js
@@ -922,7 +922,7 @@ jQuery.extend({
 		if ( fragment ) {
 			for ( var i = 0; ret[i]; i++ ) {
 				if ( jQuery.nodeName( ret[i], "script" ) ) {
-					scripts.push( ret[i].parentNode.removeChild( ret[i] ) );
+					scripts.push( ret[i].parentNode ? ret[i].parentNode.removeChild( ret[i] ) : ret[i] );
 				} else {
 					if ( ret[i].nodeType === 1 )
 						ret.splice.apply( ret, [i + 1, 0].concat(jQuery.makeArray(ret[i].getElementsByTagName("script"))) );

diff --git a/test/unit/core.js b/test/unit/core.js
@@ -899,7 +899,7 @@ test("append(String|Element|Array&lt;Element&gt;|jQuery)", function() {
 });
 
 test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() {
-	expect(6);
+	expect(7);
 	var defaultText = 'Try them out:'
 	jQuery('<b>buga</b>').appendTo('#first');
 	equals( jQuery("#first").text(), defaultText + 'buga', 'Check if text appending works' );
@@ -915,6 +915,9 @@ test("appendTo(String|Element|Array&lt;Element&gt;|jQuery)", function() {
 	jQuery([document.getElementById('first'), document.getElementById('yahoo')]).appendTo('#sap');
 	equals( expected, jQuery('#sap').text(), "Check for appending of array of elements" );
 
+	reset();
+	ok( jQuery(document.createElement("script")).appendTo("body").length, "Make sure a disconnected script can be appended." );
+
 	reset();
 	expected = document.querySelectorAll ?
 		"This link has class=\"blog\": Simon Willison's WeblogYahooTry them out:" :