Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fix a strange Chrome issue

  • Loading branch information...
1 parent fa45f25 commit 52a02383fa521c51d9996a46f03a7080dd825f11 @wycats wycats committed
Showing with 3 additions and 2 deletions.
  1. +3 −2 src/traversing.js
5 src/traversing.js
@@ -196,7 +196,8 @@ jQuery.each({
}, function( name, fn ) {
jQuery.fn[ name ] = function( until, selector ) {
- var ret = this, fn, until );
+ var ret = this, fn, until ),
+ args =;
if ( !runtil.test( name ) ) {
selector = until;
@@ -212,7 +213,7 @@ jQuery.each({
ret = ret.reverse();
- return this.pushStack( ret, name,",") );
+ return this.pushStack( ret, name, args.join(",") );

8 comments on commit 52a0238


What was the issue ? It seems it has to be known for any JS developer :)


There seems to be no test case / ticket associated with this change. Also any information on why this was done is missing.

The only thing I was able to find is a single failing test in the jQuery test suite (before this change) but with the Chrome Dev version (10.something).
In Chrome Stable (8.something) and Chrome Beta (9.something) this change isn't needed.
This strange behavior should be filed as a bug against the Chrome bug tracker as to me it looks like a chrome bug not a jQuery bug.


Here is the detail on the Chrome issue:

It appeared in the latest dev channel and is live in the chromium nightlies.

We expect to see it fixed soon, so we'll be able to revert this commit once the dev channel comes through with an update.

ajpiano has added a pull req to document this: #186


So, the fix came through 6 months ago, but this commit with the "this should be removed" note is still in 1.6.2... Was this forgotten, or is there a reason for keeping it in there?


@ajpiano see above.


Bump! Calendar has flipped 4 times through.


@LeadSongDog If you look at the current file, you will see that not only is this code gone, but that there's no longer any remnant of the functionality it was supporting:


@gibson042 Thanks, I'm still new here and stumbling around.

Please sign in to comment.
Something went wrong with that request. Please try again.