Normalize css property names to lowercase for comparisons on a .attr(…

…'style') call since IE uppercases everything
jquery · Apr 3, 2011 · 6f79bee · 6f79bee
1 parent ad2b3bc
commit 6f79bee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/attributes.js b/src/attributes.js
@@ -477,7 +477,8 @@ if ( !jQuery.support.style ) {
 	jQuery.attrHooks.style = {
 		get: function( elem ) {
 			// Return undefined in the case of empty string
-			return elem.style.cssText || undefined;
+			// Normalize to lowercase since IE uppercases css property names
+			return elem.style.cssText.toLowerCase() || undefined;
 		},
 		set: function( elem, value ) {
 			return (elem.style.cssText = "" + value);

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
@@ -135,8 +135,8 @@ test("attr(String)", function() {
 	equals( $img.attr('height'), "53", "Retrieve height attribute an an element with display:none." );
 
 	// Check for style support
-	ok( !!~jQuery('#dl').attr('style').indexOf('absolute'), 'Check style attribute getter' );
+	ok( !!~jQuery('#dl').attr('style').indexOf('position'), 'Check style attribute getter, also normalize css props to lowercase' );
-	ok( !!~jQuery('#foo').attr('style', 'position:absolute;').attr('style').indexOf('absolute'), 'Check style setter' );
+	ok( !!~jQuery('#foo').attr('style', 'position:absolute;').attr('style').indexOf('position'), 'Check style setter' );
 
 	ok( jQuery("<div/>").attr("doesntexist") === undefined, "Make sure undefined is returned when no attribute is found." );
 	ok( jQuery().attr("doesntexist") === undefined, "Make sure undefined is returned when no element is there." );