Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event: Avoid collisions between jQuery.event.special & Object.prototype #5235

Merged
merged 1 commit into from Apr 3, 2023

Conversation

mgol
Copy link
Member

@mgol mgol commented Mar 30, 2023

Summary

This is a follow-up to similar changes to data & event storages from gh-4603.

This is a breaking change as there may be code like:

jQuery.event.special.hasOwnProperty( "something" )

in the wild.

Ref gh-4603

+3 bytes

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

This is a follow-up to similar changes to data & event storages from
jquerygh-4603.

Ref jquerygh-4603
@mgol mgol added Event Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Mar 30, 2023
@mgol mgol added this to the 4.0.0 milestone Mar 30, 2023
@mgol mgol self-assigned this Mar 30, 2023
@mgol mgol removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels Apr 3, 2023
@mgol mgol merged commit bcaeb00 into jquery:main Apr 3, 2023
15 checks passed
@mgol mgol deleted the event-special-proto branch April 3, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants