Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semaphore check uses pushFailure with wrong argument order #550

Closed
jzaefferer opened this issue Apr 12, 2014 · 0 comments · Fixed by #551
Closed

Semaphore check uses pushFailure with wrong argument order #550

jzaefferer opened this issue Apr 12, 2014 · 0 comments · Fixed by #551

Comments

@jzaefferer
Copy link
Member

In https://github.com/jquery/qunit/blob/e1c3191294440eeafe8a4918bad62373d34418c1/src/core.js#L159 null, should be dropped, since source is the second argument, not the third.

See http://jsbin.com/xazepozu/1/edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core: Dropping wrong argument on semaphore check leobalter/qunit
1 participant
@jzaefferer