1.17.0 breaks phantomjs

[vampolo]

Hi,

just updated qunit and my phantomjs gets stuck in:

PhantomJS 1.9.8 (Linux) ERROR: 'TypeError: 'null' is not an object (evaluating 'toolbar.appendChild') - http://localhost:9876/base/node_modules/qunitjs/qunit/qunit.js?0db9af2b5ad31c46fe2cfa82bbe2761c44bb36f8'

[lin7sh]

Just Ignore this comment, My guess is wrong

I guess this break does not cause by version 1.17, you may have old test runner html file(like the one used in 1.11.0)
try to change

<h1 id="qunit-header">Tests</h1>
<h2 id="qunit-banner"></h2>
<div id="qunit-testrunner-toolbar"></div>
<h2 id="qunit-userAgent"></h2>
<ol id="qunit-tests"></ol>

to just

<div id="qunit"></div>

[SomethingSexy]

I mentioned this in #732 but I am getting the same error.

[leobalter]

Working on it, thanks for reporting.

Setting <div id="qunit"></div> can be used as a workaround, but that was a regression and needs to be fixed.

I'm closing this one as this is a duplicate of #732

[jlonardi]

This does not happen only on phantomjs. I am running qunit tests using karma and after qunit updated to 1.17.0 getting following errors.
Chrome:

Chrome
Chrome 41.0.2272 (Windows 7) ERROR
Uncaught TypeError: Cannot read property 'appendChild' of null
Firefox
Firefox 35.0.0 (Windows 7) ERROR
TypeError: toolbar is null

[vampolo]

I'm a bit puzzled.

Should i apply the fix described by @mkoxio <div id="qunit"></div> or should i wait for the fix ?

[leobalter]

Better wait for the fix, but you can use the new qunit markup at anytime.

from

<h1 id="qunit-header">Tests</h1>
<h2 id="qunit-banner"></h2>
<div id="qunit-testrunner-toolbar"></div>
<h2 id="qunit-userAgent"></h2>
<ol id="qunit-tests"></ol>

to

<div id="qunit"></div>