Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm proper async isolation #984

Closed
gibson042 opened this issue Apr 14, 2016 · 2 comments
Closed

Confirm proper async isolation #984

gibson042 opened this issue Apr 14, 2016 · 2 comments

Comments

@gibson042
Copy link
Member

#976 (comment) suggests that some state may be leaking.
@leobalter leobalter modified the milestone: async improvements Apr 20, 2016
@platinumazure
Copy link
Contributor

What sort of state might be leaking? Is this something that needs further investigation, or do we already have a good idea where/why this is happening?

@gibson042
Copy link
Member Author

I haven't investigated the why, but the where is in the function returned by assert.async—we should be able to pass test to resumeProcessing, but making that change breaks the test suite. So something is amiss and needs analysis.

@trentmwillis trentmwillis mentioned this issue May 24, 2016
Closed
@trentmwillis trentmwillis self-assigned this May 24, 2016
flore77 pushed a commit to flore77/qunit that referenced this issue Aug 10, 2016
@trentmwillis
All: Prevent async tests from having multiple resume timeouts
f5ba9bc 
Closes qunitjsgh-1002
Fixes qunitjsgh-984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@platinumazure @leobalter @gibson042 @trentmwillis