All: Prevent async tests from having multiple resume timeouts #1002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #984.
The root issue is that it was possible for a single async test to have multiple
resumeProcessing
timeouts. This parallel assert.async calls test is probably the easiest case to see why that would be a problem.done1
would get called and queue up aresumeProcessing
timeout.done2
would get called and queue up anotherresumeProcessing
timeout.test.semaphore
is now at0
.begin()
to resume the test suitebegin()
as well, which causes issues because we're already runningThe reason this worked without passing in
test
before is thatconfig.current
would update between the time 3 and 4 happened above which would preventbegin()
from getting called a second time.My solution is to check to see if
test
is already waiting to resume when passed intoresumeProcessing
.