Build: Append the date to local build names #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +59,7 @@ module.exports = function( grunt ) { | |||
| // Project configuration. | |||
| grunt.initConfig({ | |||
| pkg: grunt.file.readJSON( "package.json" ), | |||
| dateString: new Date().toISOString().replace( /T/, " " ).replace( /\..*Z/, "" ), | |||
There was a problem hiding this comment.
My preference would be to keep the ISO string as-is, possibly with .replace( /\.\d*/, "" ), but I approve of the overall value in timestamping jobs. User name is probably overkill, though.
All local runs have been so far appearing under a build called "local run", supposedly running for 121 days now and failing. Separating runs helps with the organization and allows to see the result of a particular run at a glance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All local runs have been so far appearing under a build called "local run",
supposedly running for 121 days now and failing. Separating runs helps with
the organization and allows to see the result of a particular run at a glance.
We could also optionally append the user name if present. Thoughts?