Selector: Detect incorrect escape handling by old Firefox #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2019
gibson042
approved these changes
Aug 20, 2019
timmywil
approved these changes
Aug 20, 2019
According to: https://www.w3.org/TR/css-syntax-3/#ident-token-diagram the escape doesn't need to be followed by a whitespace only if it's not a hex digit or a newline. However, old Firefox (3.6 - 5 only) doesn't throw if an escaped newline is not followed by a space. Fallback to Sizzle in such cases. Fixes jquerygh-454
mgol
added a commit
to mgol/sizzle
that referenced
this pull request
Oct 16, 2019
PR jquerygh-456 introduced a test catching not throwing on badly-escaped identifiers by Firefox 3.6-5. Unfortunately, it was placed just before a test Opera 10-11 fails, making Opera fail quicker and not adding a post-comma invalid selector to rbuggyQSA. This commit fixes the regression & introduces a unit test ensuring the throwing. Unfortunately, the issue is fixed in Opera 11.6 which is the lowest one Sizzle officially supports but I verified the fix manually against Opera 10.6, 11.1 & 11.5. Ref jquerygh-456
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 16, 2019
Sizzle's PR jquery/sizzle#456 introduced a test catching not throwing on badly-escaped identifiers by Firefox 3.6-5. Unfortunately, it was placed just before a test Opera 10-11 failed, making Opera fail quicker and not adding a post-comma invalid selector to rbuggyQSA. The issue was fixed in jquery/sizzle#463. This jQuery commit backports the test that Sizzle PR added as no workarounds are needed in browsers jQuery supports. Ref jquery/sizzle#456 Ref jquery/sizzle#463
3 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 21, 2019
Sizzle's PR jquery/sizzle#456 introduced a test catching not throwing on badly-escaped identifiers by Firefox 3.6-5. Unfortunately, it was placed just before a test Opera 10-11 failed, making Opera fail quicker and not adding a post-comma invalid selector to rbuggyQSA. The issue was fixed in jquery/sizzle#463. This jQuery commit backports the test that Sizzle PR added as no workarounds are needed in browsers jQuery supports. Ref jquery/sizzle#456 Ref jquery/sizzle#463
mgol
added a commit
that referenced
this pull request
Oct 21, 2019
PR gh-456 introduced a test catching not throwing on badly-escaped identifiers by Firefox 3.6-5. Unfortunately, it was placed just before a test Opera 10-11 fails, making Opera fail quicker and not adding a post-comma invalid selector to rbuggyQSA. This commit fixes the regression & introduces a unit test ensuring the throwing. Unfortunately, the issue is fixed in Opera 11.6 which is the lowest one Sizzle officially supports but I verified the fix manually against Opera 10.6, 11.1 & 11.5. Closes gh-463 Ref gh-456
mgol
added a commit
to jquery/jquery
that referenced
this pull request
Oct 21, 2019
Sizzle's PR jquery/sizzle#456 introduced a test catching not throwing on badly-escaped identifiers by Firefox 3.6-5. Unfortunately, it was placed just before a test Opera 10-11 failed, making Opera fail quicker and not adding a post-comma invalid selector to rbuggyQSA. The issue was fixed in jquery/sizzle#463. This jQuery commit backports the test that Sizzle PR added as no workarounds are needed in browsers jQuery supports. Closes gh-4516 Ref jquery/sizzle#456 Ref jquery/sizzle#463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to:
https://www.w3.org/TR/css-syntax-3/#ident-token-diagram
the escape doesn't need to be followed by a whitespace only if it's not a hex
digit or a newline. However, old Firefox (3.6 - 5 only) doesn't throw if an
escaped newline is not followed by a space. Fallback to Sizzle in such cases.
Fixes gh-454