Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector: Make selectors with leading combinators use qSA again #460

Merged
merged 1 commit into from Oct 14, 2019
Merged

Selector: Make selectors with leading combinators use qSA again #460

merged 1 commit into from Oct 14, 2019

Commits on Oct 13, 2019

  1. Selector: Make selectors with leading combinators use qSA again 

    An optimization added in jquery#431 skips the temporary IDs for selectors
not using child or descendant combinators. For sibling combinators, though, this
pushes a selector with a leading combinator to qSA directly which crashes and
falls back to a slower Sizzle route.

This commit makes selectors with leading combinators not skip the selector
rewriting. Note that after jquery/jquery#4454 & jquery#453, all modern
browsers other than Edge leverage the :scope pseudo-class, avoiding temporary
id attributes.

Ref jquerygh-431
    @mgol
    mgol committed Oct 13, 2019
    Copy the full SHA
    9cf56bb View commit details
    Browse the repository at this point in the history