Issue #222 - "Reset failed jobs" button #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in jobs.js. Add action bar above and below run table.
| resetJob($(this).parent('td')); | ||
| }); | ||
|
|
||
| $( document ).on ( 'click' , '.swarm-job-reset-failed', function () { |
There was a problem hiding this comment.
- (unexpected space in between function name and invocation parentheses)
- (unexpected space before comma)
…l test to be deleted.
|
Cleaned up the code formatting. |
| if ( $request->getSessionData( "auth" ) === "yes" && $data["jobInfo"]["ownerName"] == $request->getSessionData( "username" ) ) { | ||
| $html .= '<script>SWARM.jobInfo = ' . json_encode( $data["jobInfo"] ) . ';</script>'; | ||
| $action_bar = '<div class="form-actions swarm-item-actions">' | ||
| . ' <button class="swarm-job-reset-failed btn btn-info">Reset Failed jobs</button>' |
There was a problem hiding this comment.
Use sentence case ("Reset failed jobs") like the others.
patrickkettner
added a commit
to patrickkettner/testswarm
that referenced
this pull request
Nov 5, 2012
Abstract out reset job function in jobs.js. Add action bar above and below run table. Add an icon to each cell to allow for an individual runs to be reset (replacing the old dblclick logic).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract out reset job function in jobs.js. Add action bar above and below run table.