Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #770 #958

Closed
wants to merge 1 commit into from
Closed

Fixes #770 #958

wants to merge 1 commit into from

Conversation

evrard
Copy link

@evrard evrard commented Feb 27, 2013

This update add a lock flag that will avoid multiple click() call while the effect is not over. This fix solve the angry clicks on slideshow forward/backward buttons and probably more issues.

Another way to solve multiple click() issues would be to stack click() call and execute them one after the other.

This update add a lock flag that will avoid multiple click() call while the effect is not over. This fix solve the angry clicks on slideshow forward/backward buttons and probably more issues.

Another way to solve multiple click() issues would be to stack click() call and execute them one after the other.
@evrard
Copy link
Author

evrard commented Feb 27, 2013

Another idea (my best one) about multiple click() issues would be that:

  • keep the lock flag as is, so on click, lock, and on effect callback, release it
  • when click() is called while it is locked, keep in mind the index to load, and apply it on effect callback

So the process should look like :

  • call click( i1 ): assign lock and launch effect
  • call click( i2 ): locked, keep i2 in mind
  • click( i1 ) is over: release lock and call click( i2 )
  • call click( i3 ): locked, keep i3 in mind
  • call click( i4 ): locked, keep i4 in mind
  • click( i2 ) is over: release lock and call click( i4 )

What do you think about it ?

Loops

@alibby251
Copy link
Contributor

Hi evrard,

Thanks for creating this patch - any chance you could please re-base it on the current dev branch? I'm using this to form what will become Tools 1.2.8.

@alibby251 alibby251 closed this Feb 27, 2013
@evrard evrard mentioned this pull request Mar 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants