Fix monkey patch for Rollout 1.2.0 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Rollout makes the second argument of `active?` optional -- if nil it checks if a feature is globally active. Adding the default to the monkey patch should be backwards compatible with older versions of Rollout for non-pathological cases since there is no arity change.
|
Good case for groaning about monkey patches 😩 I tested something on a feature branch where RolloutUI wasn't installed yet, merged the branch to mainline where it was installed, failed to adequately test the scenario again after the merge, and it cost me smooth dark launch of a new feature after deploying it and discovering the need for this patch 😭 |
|
+1 |
1 similar comment
|
+1 |
|
Thanks Ches! |
jrallison
added a commit
that referenced
this pull request
Jan 8, 2013
Fix monkey patch for Rollout 1.2.0
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Rollout makes the second argument of
active?optional -- ifnil it checks if a feature is globally active. Adding the default to the
monkey patch should be backwards compatible with older versions of
Rollout for non-pathological cases since there is no arity change.