Ensure the count updater ignores jobs that are in stopped state. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stopped Nomad jobs can still return through an API call and therefore be present during the dynamicGroupCountUpdater func. In situations where a job deployed with the same as a stopped job, the deploymend will update the group counts based on the stopped job which should be avoided. Closes #105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopped Nomad jobs can still return through an API call and
therefore be present during the dynamicGroupCountUpdater func. In
situations where a job deployed with the same as a stopped job,
the deploymend will update the group counts based on the stopped
job which should be avoided.
Closes #105