Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamicGroupCountUpdater doesn't take into account job status #105

Closed
jrasell opened this issue Feb 8, 2018 · 0 comments
Closed

dynamicGroupCountUpdater doesn't take into account job status #105

jrasell opened this issue Feb 8, 2018 · 0 comments

Comments

@jrasell
Copy link
Member

jrasell commented Feb 8, 2018

Description

If you stop a Nomad job, it is still present until the GC is run. When the dynamicGroupCountUpdater function runs it does not take into account jobs which may return but be stopped, and therefore can update a count based on a stopped job. This should be updated so that stopped jobs are ignored from being used in the dynamicGroupCountUpdater function.

Output of levant version:

Levant v0.1.0-dev

Output of nomad version:

Nomad v0.7.1 (0b295d399d00199cfab4621566babd25987ba06e)
@jrasell jrasell added the bug label Feb 8, 2018
jrasell added a commit that referenced this issue Feb 8, 2018
@jrasell
Ensure the count updater ignores jobs that are in stopped state.
cda88d1 
Stopped Nomad jobs can still return through an API call and
therefore be present during the dynamicGroupCountUpdater func. In
situations where a job deployed with the same as a stopped job,
the deploymend will update the group counts based on the stopped
job which should be avoided.

Closes #105
@jrasell jrasell mentioned this issue Feb 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrasell