Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] version command information is not populate #2

Open
jrasell opened this issue Oct 26, 2018 · 1 comment
Open

[bug] version command information is not populate #2

jrasell opened this issue Oct 26, 2018 · 1 comment
Labels
bug Something isn't working build

Comments

@jrasell
Copy link
Owner

jrasell commented Oct 26, 2018

When running the nomad-toast version command no details have been correctly populated:

nomad-toast version nomad-toast
 Date:
 Commit:
 Branch:
 State:
 Summary:
@jrasell jrasell added bug Something isn't working build labels Oct 26, 2018
ExalDraen pushed a commit to ExalDraen/nomad-toast that referenced this issue May 31, 2019
(jrasell#2) Update cfg to ensure version cmd works
03c1a0f 
This is done by ensuring that the import path passed to the linker is
correct - this is needed because the build constants are not in the
main package, so the default import path of `main.` doesn't work.

I've tested this works locally with `make build` and also tested
goreleaser with
```
goreleaser release --rm-dist --skip-publish --config=./cmd/nomad-toast/goreleaser.yml --skip-validate
```
@ExalDraen
Copy link
Contributor

@jrasell I've created a PR that addresses it, please have a look!

jrasell added a commit that referenced this issue Jun 1, 2019
@jrasell
Merge pull request #20 from ExalDraen/feature/fix-version-cmd
961dcfe 
(#2) Update cfg to ensure version cmd works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ExalDraen @jrasell