Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding owner to config keys and analytics #230

Merged
merged 1 commit into from
May 3, 2020

Conversation

jraska
Copy link
Owner

@jraska jraska commented May 3, 2020

Problem being solved

  • Ownership of config and analytics is not clear after some time passes.
  • We need to know if these keys are still used or not - they are usually used in external system and there is no visibility on this in code.
  • Config and analytics names can be scattered around the code.

The solution

  • Ownership configuration is moved into code and is enforced by config and analytics API
  • Enforcing same format of introducing keys - no discussion of constant/not constant.
  • Configs and analytics keys are easily searchable - see screenshot
  • Owner needs to know if the keys are still useful - if the information is unknown, it means not useful.
Analytics Keys with owners Config Keys with owners
Screenshot 2020-05-03 at 15 57 44 Screenshot 2020-05-03 at 15 59 15

When searching for constructor, we can export our keys like into something like this:
analytics.txt

@jraska jraska merged commit 07fdc23 into master May 3, 2020
@jraska jraska deleted the add-owner-to-configs-and-analytics branch May 3, 2020 14:17
@jraska jraska added this to the 0.22.1 milestone Mar 19, 2021
@jraska
Copy link
Owner Author

jraska commented Mar 19, 2021

This PR was released with 0.22.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant