Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-app-update implementation #317

Merged
merged 4 commits into from
Oct 22, 2020
Merged

Add in-app-update implementation #317

merged 4 commits into from
Oct 22, 2020

Conversation

jraska
Copy link
Owner

@jraska jraska commented Oct 19, 2020

Implementation

  • Basically follows https://developer.android.com/guide/playcore/in-app-updates only using abstractions like TopActivityProvider and SnackbarDisplay
  • Flag used in_app_update_strategy with domain Flexible|Immediate|Off|empty string everything else triggers runtime non-fatal crash
  • It is challenging to test this properly - so now no proper automation :shame

Notes

  • When set download on Wifi, then the update available doesn't show for the next time.
  • The isUpdateTypeAllowed() method is confusing. It is not controlled by Play Store as. I thought, but by type of update - for example when the update s downloaded only immediate update is available.

Visual

Config controlling if the app shoudl even check for updates - it adds as flexibility to target old versions, ccohorts or any other user group.
Screenshot 2020-10-23 at 00 54 36

Flexible Immediate Update in progress
Screenshot_20201023-004928 Screenshot_20201023-004849 Screenshot_20201023-004941

@stale
Copy link

stale bot commented Oct 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 22, 2020
@jraska jraska removed the stale label Oct 22, 2020
@jraska jraska marked this pull request as ready for review October 22, 2020 23:01
@jraska jraska merged commit 6d2538b into master Oct 22, 2020
@jraska jraska deleted the add-in-app-updates branch October 22, 2020 23:07
@jraska jraska added this to the 0.22.1 milestone Mar 19, 2021
@jraska
Copy link
Owner Author

jraska commented Mar 19, 2021

This PR was released with 0.22.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement update API from Google Play
1 participant