Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to assert on each build #184

Merged
merged 3 commits into from Sep 1, 2022
Merged

Conversation

jraska
Copy link
Owner

@jraska jraska commented Sep 1, 2022

  • Engineers typically won't run the assertion locally - the use case it to run the assertions as part of any build to immediately notify engineers at the first build after added dependency.
  • assertOnAnyBuild option added to configuration with false as a default
  • The assertion typically takes < 10ms (tried this graph on M1 machine), therefore running it on any build takes neglectable amount of time
  • Related to Explore immediate check on Gradle sync #166
  • The Explore immediate check on Gradle sync #166 will be resolved after the new version is released and documentation is added to README.

Performance impact

  • On each build measured 2.4ms for 1000 modules graph on M1 Pro machine, therefore the overhead is neglectable for any build even on older machines.

@jraska jraska enabled auto-merge (squash) September 1, 2022 00:14
@jraska jraska merged commit 0e9ccda into master Sep 1, 2022
@jraska jraska deleted the add-assert-on-each-build branch September 1, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant