Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default character encoding #350

Merged
merged 1 commit into from Jul 31, 2018

Conversation

samihda
Copy link
Contributor

@samihda samihda commented Jul 31, 2018

I changed the default character encoding in the generated preview document to UTF-8.

No breaking changes were introduced, but I'm happy to adjust this in case we're okay with dropping markdown-content-type altogether and switching to the charset attribute instead.

Related Issue

I came across this when text doesn't render properly in the preview. It was German text in my case, but I'm sure it affects others too. This should also fix #340.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

@jrblevin jrblevin merged commit 5bbad65 into jrblevin:master Jul 31, 2018
@jrblevin
Copy link
Owner

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML preview is not UTF-8
2 participants