Download remote images and cache them #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermiculus
force-pushed
the
remote-images
branch
from
0d18ec3
to
d043054
Compare
|
I'll say right now that there should be a good way to invalidate the image cache (or not even have one) but I have a poor track record with implementing expiring caches 'nicely'. |
If non-nil, this option will download images from a remote server (if the URL is given with a white-listed protocol; by default only allowing HTTPS) and display them during the execution of `markdown-display-inline-images'. Absolute process-specific caching is employed to avoid double-downloading images. No `nice' means is yet given for the invalidation of this cache.
vermiculus
force-pushed
the
remote-images
branch
from
d043054
to
7949fdf
Compare
|
Very nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If non-nil, this option will download images from a remote server (if the URL is given with a white-listed protocol; by default only allowing HTTPS) and display them during the execution of
markdown-display-inline-images.Absolute process-specific caching is employed to avoid double-downloading images. No 'nice' means is yet given for the invalidation of this cache.
Related Issue
#316 -- Didn't even know this existed.
This was prompted by magit/forge#41.
Type of Change
Checklist
make test).Re new tests: unknown how to test this.