Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown-enter-key doesn't delete empty checkbox list #786

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

kuranari
Copy link
Contributor

@kuranari kuranari commented Aug 5, 2023

Description

I have updated markdown-enter-key to delete empty checkboxes.
I think this action is better, similar to how GitHub's issue editor handles it.

Issue

Expected Behavior:

When pressing enter on an empty checkbox list, the list should be deleted.

Actual Behavior:

A new list with a checkbox is added to the next line.

Steps to Reproduce

When I pressed enter on an empty checkbox item (with the cursor located after the checkbox),

- [x] 

a new list item was added, resulting in the following:

- [x] 
- [ ]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

@syohex syohex merged commit 8781cf9 into jrblevin:master Aug 7, 2023
4 checks passed
@syohex
Copy link
Collaborator

syohex commented Aug 7, 2023

Thanks

@kuranari kuranari deleted the markdown-enter-key branch August 8, 2023 05:28
@kuranari kuranari mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants