Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push mark before jumping to footnote #793

Merged
merged 1 commit into from Aug 17, 2023

Conversation

slotThe
Copy link
Contributor

@slotThe slotThe commented Aug 16, 2023

Description

When inserting a (small) footnote, it is often very convenient to jump back to the main text with C-u C-SPC instead of using markdown-footnote-return. However, this can only be done if markdown-insert-footnote pushes to the mark ring before jumping, so do that.

Type of Change

  • [n/a] Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • [n/a] New feature (non-breaking change which adds functionality)
  • [n/a] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.

  • [n/a] I have updated the documentation in the README.md file if necessary.

  • [n/a] I have added an entry to CHANGES.md.

    Not significant enough to warrant this, I think.

  • [n/a] I have added tests to cover my changes.

    Not significant enough to warrant this, I think.

  • All new and existing tests passed (using make test).

When inserting a small footnote, it is often very convenient to jump
back to the main text with C-u C-SPC instead of using
`markdown-footnote-return'. However, this can only be done if
`markdown-insert-footnote' pushes to the mark ring before jumping, so do
that.
@syohex
Copy link
Collaborator

syohex commented Aug 17, 2023

org-footnote-new sets marker like this so I think this behavior looks good.

@syohex syohex merged commit bc0c0b9 into jrblevin:master Aug 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants