Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide trailing whitespace when hiding markup #826

Merged
merged 1 commit into from Mar 11, 2024

Conversation

jimporter
Copy link
Contributor

Description

When hiding markup, e.g. via markdown-view-mode, the trailing whitespace markup for line breaks doesn't get hidden. This patch changes it so that the whitespace is hidden when hiding other markup. In practice, this just makes the " " invisible and nothing else; then, we let the newline do its usual thing.

(In the future, I could imagine markdown-view-mode handling soft newlines differently, so that something like foo\nbar is displayed as foo bar. Then, we'd probably want to do something special to mark the newline in \n as a hard newline.)

Related Issue

See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69647

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have updated the documentation in the README.md file if necessary.
  • I have added an entry to CHANGES.md.
  • I have added tests to cover my changes.
  • All new and existing tests passed (using make test).

@syohex syohex merged commit b7f7da9 into jrblevin:master Mar 11, 2024
4 checks passed
@syohex
Copy link
Collaborator

syohex commented Mar 11, 2024

Thanks

@jimporter jimporter deleted the line-breaks-are-markup branch March 12, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants